Skip to content

Simplify refactored OpenApiFactory collectPaths()#4199

Merged
soyuka merged 2 commits into
api-platform:2.6from
guilliamxavier:patch-1
Apr 12, 2021
Merged

Simplify refactored OpenApiFactory collectPaths()#4199
soyuka merged 2 commits into
api-platform:2.6from
guilliamxavier:patch-1

Conversation

@guilliamxavier

@guilliamxavier guilliamxavier commented Apr 9, 2021

Copy link
Copy Markdown
Contributor
Q A
Branch? 2.6
Bug fix? no
New feature? no
Deprecations? no
Tickets Follows #3407 (comment) and #4138
License MIT
Doc PR

The $links array is passed by reference and $schemas is now an \ArrayObject (automatically passed by "handle"), so both get appended to (like $paths) at each call to collectPaths()

@guilliamxavier guilliamxavier reopened this Apr 9, 2021
@guilliamxavier

Copy link
Copy Markdown
Contributor Author

Oops I had committed too fast, now fixed, but I can't squash on GitHub :s

@guilliamxavier guilliamxavier marked this pull request as ready for review April 9, 2021 13:21
@alanpoulain alanpoulain requested a review from soyuka April 9, 2021 14:46
@soyuka soyuka merged commit cbc1633 into api-platform:2.6 Apr 12, 2021
@soyuka

soyuka commented Apr 12, 2021

Copy link
Copy Markdown
Member

thanks @guilliamxavier

@guilliamxavier guilliamxavier deleted the patch-1 branch April 12, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants